Re: [PATCH v3 03/18] driver core: platform: Rename platform_dma_configure()

From: Lu Baolu
Date: Mon Dec 06 2021 - 20:21:53 EST


On 12/6/21 11:04 PM, Jason Gunthorpe wrote:
On Mon, Dec 06, 2021 at 06:47:45AM -0800, Christoph Hellwig wrote:
On Mon, Dec 06, 2021 at 10:45:35AM -0400, Jason Gunthorpe via iommu wrote:
IIRC the only thing this function does is touch ACPI and OF stuff?
Isn't that firmware?

AFAICT amba uses this because AMBA devices might be linked to DT
descriptions?
But DT descriptions aren't firmware. They are usually either passed onb
the bootloader or in some deeply embedded setups embedded into the
kernel image.
Pedenatically yes, but do you know of a common word to refer to both
OF and ACPI that is better than firmware?:)

If the firmware_ name is confusing, how about common_dma_configure()?
Or, copy the 6 lines of code to amba bus driver?

Best regards,
baolu