Re: [PATCH v4 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use

From: Martin Blumenstingl
Date: Mon Dec 06 2021 - 16:14:38 EST


On Sun, Dec 5, 2021 at 10:59 PM Amjad Ouled-Ameur
<aouledameur@xxxxxxxxxxxx> wrote:
>
> Use reset_control_rearm() call if an error occurs in case
> phy_meson8b_usb2_power_on() fails after reset() has been called, or in
> case phy_meson8b_usb2_power_off() is called i.e the resource is no longer
> used and the reset line may be triggered again by other devices.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework, use of reset_control_reset() on shared reset line should
> be balanced with reset_control_rearm().
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@xxxxxxxxxxxx>
> Reported-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>