Re: [PATCH] staging: rtl8712: Fix alignment checks

[Dan Carpenter]

On Mon, Dec 06, 2021 at 08:19:49AM +0800, Ngo Tak Fong wrote:
> Fixed two CHECKs of Alignment should match open parenthesis.
> 
> Signed-off-by: Ngo Tak Fong <simon.fodin@xxxxxxxxx>
> ---
>  drivers/staging/rtl8712/rtl8712_efuse.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 4f3b54a7c3be..3555f612a066 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -300,16 +300,15 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr)
>  		for (i = 0; i < PGPKG_MAX_WORDS; i++) {
>  			if (BIT(i) & word_en) {

The real problem is this code is jammed up against the right hand side
of the screen.  Just flip this condition around and pull the code in
one tab.

			if (!(BIT(i) & word_en)
				continue;

>  				if (BIT(i) & pkt.word_en) {
> -					if (efuse_one_byte_read(
> -							adapter, addr,
> -							&value))
> +					if (efuse_one_byte_read(adapter,
> +								addr,
> +								&value))

reards,
dan carpenter