Re: [PATCH v8 08/14] livepatch: only match unique symbols when using FG-KASLR

From: Josh Poimboeuf
Date: Mon Dec 06 2021 - 01:04:03 EST


On Fri, Dec 03, 2021 at 11:05:54AM +0100, Peter Zijlstra wrote:
> On Thu, Dec 02, 2021 at 11:32:08PM +0100, Alexander Lobakin wrote:
> > If any type of function granular randomization is enabled, the sympos
> > algorithm will fail, as it will be impossible to resolve symbols when
> > there are duplicates using the previous symbol position.
> >
> > We could override sympos to 0, but make it more clear to the user
> > and bail out if the symbol is not unique.
>
> Since we're going lots of horrendous things already, why can't we fix
> this duplicate nonsense too?

I assume you mean using this new linker flag: "-z unique-symbol"

https://sourceware.org/bugzilla/show_bug.cgi?id=26391

--
Josh