Re: [PATCH 1/2] kbuild: move headers_check.pl to usr/include/

From: Masahiro Yamada
Date: Sun Dec 05 2021 - 20:26:42 EST


On Mon, Dec 6, 2021 at 10:16 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2021-12-06 at 10:05 +0900, Masahiro Yamada wrote:
> > This script is only used by usr/include/Makefile. Make it local to
> > the directory.
> >
> > Update the comment in include/uapi/linux/soundcard.h because
> > 'make headers_check' is no longer functional.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> >
> > include/uapi/linux/soundcard.h | 2 +-
> > usr/include/Makefile | 2 +-
> > {scripts => usr/include}/headers_check.pl | 0
> > 3 files changed, 2 insertions(+), 2 deletions(-)
> > rename {scripts => usr/include}/headers_check.pl (100%)
> >
> > diff --git a/include/uapi/linux/soundcard.h b/include/uapi/linux/soundcard.h
> []
> > @@ -1051,7 +1051,7 @@ typedef struct mixer_vol_table {
> > * the GPL version of OSS-4.x and build against that version
> > * of the header.
> > *
> > - * We redefine the extern keyword so that make headers_check
> > + * We redefine the extern keyword so that scripts/headers_check.pl
>
> Didn't you just move/rename this file?

My bad - it is the old file path.

Thanks, I will fix it.





> > diff --git a/scripts/headers_check.pl b/usr/include/headers_check.pl
> > similarity index 100%
> > rename from scripts/headers_check.pl
> > rename to usr/include/headers_check.pl
>
>


--
Best Regards
Masahiro Yamada