Re: [PATCH v3 5/5] drivers/node: Show in sysfs node's crypto capabilities

From: Greg KH
Date: Sat Dec 04 2021 - 12:30:17 EST


On Sat, Dec 04, 2021 at 01:35:15PM -0300, Martin Fernandez wrote:
> On 12/4/21, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > You forgot a Documentation/ABI/ update for this new sysfs file you
> > added :(
> >
>
> Damn, I forgot to add it to the patch. It will be in my next patch,
> this is what it looks like:
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-node
> b/Documentation/ABI/testing/sysfs-devices-node
> new file mode 100644
> index 000000000000..ab46fdd3f6a8
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-node
> @@ -0,0 +1,10 @@
> +What: /sys/devices/system/node/nodeX/crypto_capable
> +Date: October 2021

October is long gone :(

> +Contact: Martin Fernandez <martin.fernandez@xxxxxxxxxxxxx>
> +Users: fwupd

Maybe a link to what 'fwupd' is?

> +Description:
> + This value is 1 if all system memory in this node is
> + marked with EFI_MEMORY_CPU_CRYPTO, indicating that the
> + system memory is capable of being protected with the
> + CPU’s memory cryptographic capabilities. It is 0
> + otherwise.

thanks,

greg k-h