Re: [PATCH -mm 3/5] samples/bpf/tracex2: replace hard-coded 16 with TASK_COMM_LEN

From: Alexei Starovoitov
Date: Sat Dec 04 2021 - 11:46:01 EST


On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> diff --git a/samples/bpf/tracex2_user.c b/samples/bpf/tracex2_user.c
> index 1626d51dfffd..b728a946d83d 100644
> --- a/samples/bpf/tracex2_user.c
> +++ b/samples/bpf/tracex2_user.c
> @@ -12,6 +12,7 @@
>
> #define MAX_INDEX 64
> #define MAX_STARS 38
> +#define TASK_COMM_LEN 16
>
> /* my_map, my_hist_map */
> static int map_fd[2];
> @@ -28,7 +29,7 @@ static void stars(char *str, long val, long max, int width)
> }
>
> struct task {
> - char comm[16];
> + char comm[TASK_COMM_LEN];

Also Nack.