RE: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes

[Song Bao Hua (Barry Song)]

> -----Original Message-----
> From: Brice Goglin [mailto:Brice.Goglin@xxxxxxxx]
> Sent: Saturday, December 4, 2021 10:48 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Heiko Carstens <hca@xxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Rafael J . Wysocki
> <rafael@xxxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>;
> Len Brown <len.brown@xxxxxxxxx>; Thomas Richter <tmricht@xxxxxxxxxxxxx>; Ian
> Rogers <irogers@xxxxxxxxxx>
> Subject: Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes
> 
> Le 04/12/2021 à 10:07, Song Bao Hua (Barry Song) a écrit :
> >
> > Could you give me one minute?
> >
> > +Brice
> >
> > I'd like to hear some feedbacks from hwloc if there
> > is a chance to break userspace and if userspace depends
> > on the existence of sysfs even though the topology
> > doesn't exist.
> >
> > If no, I feel it is safe to take.
> >
> 
> Hello
> 
> If the question is whether hwloc *requires* cluster/die/book/drawer
> sysfs files to exist, then the answer is no. We have to support old
> kernels without those files anyway.

Thanks for clarification, Brice. I saw hwloc is reading sysfs
drawer, book and cluster. But since it doesn't assume their
existence in sysfs, I have more confidence on this patchset
now.

Greg, please ignore my comment then :-)

> 
> Brice
> 
> 

Thanks
Barry