Re: [RFC PATCH 1/6] drivers: crypto: Updated Makefile for xilinx subdirectory

[Michal Simek]

On 11/29/21 20:20, Harsha wrote:
> This patch updates the Makefile for xilinx subdirectory.
> Currently the xilinx subdirectory includes only zynqmp-aes-gcm.c.
> Since this patch series adds zynqmp-sha.c in the xilinx subdirectory,
> so the Makefile needs to be updated.

You should change this description.

CONFIG_CRYPTO_DEV_ZYNQMP_AES protects zynqmp-aes-gcm.o and it is used 
twice and it is enough to use it once.

> Signed-off-by: Harsha <harsha.harsha@xxxxxxxxxx>
> ---
>   drivers/crypto/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
> index 1fe5120..0a4fff2 100644
> --- a/drivers/crypto/Makefile
> +++ b/drivers/crypto/Makefile
> @@ -47,7 +47,7 @@ obj-$(CONFIG_CRYPTO_DEV_VMX) += vmx/
>   obj-$(CONFIG_CRYPTO_DEV_BCM_SPU) += bcm/
>   obj-$(CONFIG_CRYPTO_DEV_SAFEXCEL) += inside-secure/
>   obj-$(CONFIG_CRYPTO_DEV_ARTPEC6) += axis/
> -obj-$(CONFIG_CRYPTO_DEV_ZYNQMP_AES) += xilinx/
> +obj-y += xilinx/
>   obj-y += hisilicon/
>   obj-$(CONFIG_CRYPTO_DEV_AMLOGIC_GXL) += amlogic/
>   obj-y += keembay/

This should be regular patch not just RFC.  When this is fixed feel free 
to add my

Reviewed-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal