Re: [EXT] Re: [PATCH net-next 2/2] net: stmmac: make stmmac-tx-timeout configurable in Kconfig

[Heiner Kallweit]

On 02.12.2021 11:28, Xiaoliang Yang wrote:
> Hi Heiner,
> 
> On Dec 02, 2021 at 16:13:20, Heiner Kallweit wrote:
>>> stmmac_tx_timeout() function is called when a queue transmission
>>> timeout. When Strict Priority is used as scheduling algorithms, the
>>> lower priority queue may be blocked by a higher prority queue, which
>>> will lead to tx timeout. We don't want to enable the tx watchdog
>>> timeout in this case. Therefore, this patch make stmmac-tx-timeout
>> configurable.
>>>
>> Your patch just disables the timeout handler, the WARN_ONCE() would still fire.
>> And shouldn't this be a runtime setting rather than a compile-time setting?
>>
> I tried to disable it in stmmac_tx_timeout() at runtime, the WARN_ONCE() will still be called from dev_watchdog() in sch_generic.c. It seems only when the timeout handler is NULL can disable the netdev watchdog up. So I did this in compile-time setting.
> 
The issue you're trying to fix is not driver-specific. Therefore the solution
should be added to net core.

> Regards,
> Xiaoliang
>