RE: [PATCH v11 1/5] device property: Add fwnode_iomap()

[Anand Ashok Dumbre]

Hi Andy,

> -----Original Message-----
> From: Anand Ashok Dumbre <ANANDASH@xxxxxxxxxx>
> Sent: Tuesday 30 November 2021 9:58 PM
> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; jic23@xxxxxxxxxx; lars@xxxxxxxxxx; linux-
> iio@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>; Michal Simek
> <michals@xxxxxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx;
> linux-acpi@xxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH v11 1/5] device property: Add fwnode_iomap()
> 
> Hi Andy,
> 
> Thanks for the review.
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Sent: Thursday 25 November 2021 11:42 AM
> > To: Anand Ashok Dumbre <ANANDASH@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; jic23@xxxxxxxxxx; lars@xxxxxxxxxx;
> > linux- iio@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>; Michal Simek
> > <michals@xxxxxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx;
> > linux-acpi@xxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v11 1/5] device property: Add fwnode_iomap()
> >
> > On Wed, Nov 24, 2021 at 10:54:03PM +0000, Anand Ashok Dumbre wrote:
> > > This patch introduces a new helper routine - fwnode_iomap(), which
> > > allows to map the memory mapped IO for a given device node.
> > >
> > > This implementation does not cover the ACPI case and may be expanded
> > > in the future. The main purpose here is to be able to develop
> > > resource provider agnostic drivers.
> >
> > ...
> >
> > > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int
> > index) {
> >
> > > +	if (is_of_node(fwnode))
> > > +		return of_iomap(to_of_node(fwnode), index);
> >
> > It seems this part should be wrapped in some ifdeffery according to
> > kbuild bot report.
> 
> I see that of_iomap is wrapped in #ifdef I will fix that and send a new patch.

I am unable to reproduce the conditions for the error shown by the kernel bot.
Not sure if I am doing something wrong. Any help/suggestion would be appreciated to fix this issue.

> 
> >
> > > +	return NULL;
> > > +}
> > > +EXPORT_SYMBOL(fwnode_iomap);
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> 
> Thanks,
> Anand

Thanks and Regards,
Anand