Re: [PATCH 2/3] selftests/resctrl: Return KSFT_SKIP(4) if resctrl filessystem is not supported or resctrl is not run as root

[Reinette Chatre]

Hi Shaopeng Tan,

On 11/30/2021 6:36 PM, tan.shaopeng@xxxxxxxxxxx wrote:
> Hi Reinette
>   
> > (subject line and commit message: filessystem -> file system)
> Thanks.
>   
> > On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
> > > From: "Tan, Shaopeng" <tan.shaopeng@xxxxxxxxxxxxxx>
> > >
> > > To unify the return code of resctrl_tests with the return code of
> > > selftest set, return KSFT_SKIP (4) if resctrl filessystem is not
> > > supported or resctrl is not run as root.
> >
> > Could you please elaborate how changing ksft_exit_fail_msg() to
> > ksft_exit_skip() accomplishes the goal of unifying the return code?
> > What is wrong with using ksft_exit_fail_msg()?
>
> In selftest framwork,
> if a test need root privileges, but it is run as user privileges,
> the test result will counted as a SKIP item, instead of a FAIL item.

Thank you for the details. I think it is important to highlight that a 
skipped test is marked as successful to not unnecessarily report a 
feature failure when there actually is a failure in the test environment.

Reinette