Re: [PATCH] Documentation: Fill the gaps about entry/noinstr constraints

From: Thomas Gleixner
Date: Wed Dec 01 2021 - 15:28:43 EST


On Wed, Dec 01 2021 at 18:23, Mark Rutland wrote:
> On Wed, Dec 01, 2021 at 07:14:41PM +0100, Thomas Gleixner wrote:
>> Mark,
>>
>> On Wed, Dec 01 2021 at 10:56, Mark Rutland wrote:
>> > On Tue, Nov 30, 2021 at 11:31:30PM +0100, Thomas Gleixner wrote:
>> >> ---
>> >> Documentation/core-api/entry.rst | 268 +++++++++++++++++++++++++++++++++++++++
>> >> Documentation/core-api/index.rst | 8 +
>> >> kernel/entry/common.c | 1
>> >
>> > I think the change to kernel/entry/common.c got included by accident?
>>
>> That's what I get from doing such things 30 minutes before midnight...
>
> Ah, I had debugged it down to:
>
> nobikeshed void do_rst(struct tglx *tglx);
> {
> aargh_rst_enter(tglx);
>
> documentation_begin();
> invoke_editor(tglx);
> documentation_end();
> }
>
> ... where I think we forgot the:
>
> enter_from_sleep_mode(tglx);
> ...
> exit_to_sleep_mode(tglx);

ROTFL. You made my day!