Re: [PATCH v3 2/2] block: cancel all throttled bios in del_gendisk()

[Tejun Heo]

On Wed, Dec 01, 2021 at 05:40:14PM +0800, Yu Kuai wrote:
> +	/*
> +	 * hold queue_lock to prevent concurrent with dispatching
> +	 * throttled bios by timer.
> +	 */
> +	spin_lock_irq(&q->queue_lock);
> +	rcu_read_lock();

Can you see whether it still needs rcu_read_lock() while holding queue_lock?
Now that all RCU flavors are merged, I think just holding the queue_lock
should be enough here.

Looks good otherwise.

Thanks.

-- 
tejun