Re: [PATCH v6 03/29] KVM: Resync only arch fields when slots_arch_lock gets reacquired

[Maciej S. Szmigiero]

On 01.12.2021 02:07, Sean Christopherson wrote:
> On Tue, Nov 30, 2021, Maciej S. Szmigiero wrote:
> > From: "Maciej S. Szmigiero" <maciej.szmigiero@xxxxxxxxxx>
> >
> > There is no need to copy the whole memslot data after releasing
> > slots_arch_lock for a moment to install temporary memslots copy in
> > kvm_set_memslot() since this lock only protects the arch field of each
> > memslot.
> >
> > Just resync this particular field after reacquiring slots_arch_lock.
> >
> > Note, this also eliminates the need to manually clear the INVALID flag
> > when restoring memslots; the "setting" of the INVALID flag was an
> > unwanted side effect of copying the entire memslots.
> >
> > Since kvm_copy_memslots() has just one caller remaining now
> > open-code it instead.
> >
> > Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@xxxxxxxxxx>
> > [sean: tweak shortlog, note INVALID flag in changelog, revert comment]
> > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
>
> Heh, I think you can drop my SoB?  This is new territory for me, I don't know the
> rules for this particular situation.
>
> Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Will replace your SoB with your R-b on this patch then.

Thanks,
Maciej