Re: [PATCH] cgroup: Trace event cgroup id fields should be u64

[William Kucharski]

I'll break it up into two patches if you prefer, one that makes the stylistic change and then
another that makes the u64 change.

> On Dec 1, 2021, at 7:54 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> On Wed, Dec 01, 2021 at 07:40:43AM -0700, William Kucharski wrote:
>> Various trace event fields that store cgroup IDs were declared
>> as ints, but cgroup_id(() returns a u64 and the conversion was
>> not intended.
>> 
>> Also remove extraneous spaces in fields that are no longer proper C style.
> 
> Shouldn't this be 2 different patches?  When writing "also" that's a
> huge hint that the patch should be split up.
> 
> So one for the bugfix, and one for the coding style change?
> 
> thanks,
> 
> greg k-h