Re: [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes

[Konrad Dybcio]

On 01.12.2021 08:29, Vinod Koul wrote:
> Add the reserved memory nodes for SM8450. This is based on the downstream
> documentation.
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 221 +++++++++++++++++++++++++++
>  1 file changed, 221 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index f0b9e80238a2..79aead4cba66 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -310,6 +310,227 @@ CLUSTER_PD: cpu-cluster0 {
>  		};
>  	};
>  
> +	reserved_memory: reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		hyp_mem: memory@80000000 {
> +			no-map;
> +			reg = <0x0 0x80000000 0x0 0x600000>;
> +		};

All nodes in this patch put no-map before reg, which is precisely not the way

it's done in all other qcom DTs...

[...]


> +
> +		/* uefi region can be reused by apps */

What apps? Facebook? TikTok? Capitalization makes a difference in this

specific case..

> +
> +		/* Linux kernel image is loaded at 0xa0000000 */
> +
> +		oem_vm_mem: memory@bb000000 {
> +			no-map;
> +			reg = <0x0 0xbb000000 0x0 0x5000000>;
> +		};
> +

[...]


Konrad