Re: [EXT] [PATCHv3] ethernet: aquantia: Try MAC address from device tree

From: Igor Russkikh
Date: Wed Dec 01 2021 - 03:13:08 EST


Hi Tianhao,

> Apple M1 Mac minis (2020) with 10GE NICs do not have MAC address in the
> card, but instead need to obtain MAC addresses from the device tree. In
> this case the hardware will report an invalid MAC.
>
> Currently atlantic driver does not query the DT for MAC address and will
> randomly assign a MAC if the NIC doesn't have a permanent MAC burnt in.
> This patch causes the driver to perfer a valid MAC address from OF (if
> present) over HW self-reported MAC and only fall back to a random MAC
> address when neither of them is valid.
>
> Signed-off-by: Tianhao Chai <cth451@xxxxxxxxx>
Reviewed-by: Igor Russkikh <irusskikh@xxxxxxxxxxx>

Regards,
Igor