Re: [PATCH 03/11] ASoC: cs35l41: Move regmap config struct to shared code

[Mark Brown]

On Tue, Nov 23, 2021 at 04:31:41PM +0000, Lucas Tanure wrote:
> Move regmap configs to external include so CS35L41 HDA
> driver can re-use it.
> 
> Signed-off-by: Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  include/sound/cs35l41.h        |  6 +++++-
>  sound/soc/codecs/cs35l41-i2c.c | 15 ---------------
>  sound/soc/codecs/cs35l41-lib.c | 34 ++++++++++++++++++++++++++++++++--
>  sound/soc/codecs/cs35l41-spi.c | 16 ----------------
>  sound/soc/codecs/cs35l41.h     |  6 ------

It looks like they actually end up in a .c file rather than an include
which is what I'd expect (and I don't see anything fishy like including
.c files).

> -const struct reg_default cs35l41_reg[CS35L41_MAX_CACHE_REG] = {
> +const struct reg_default cs35l41_reg[] = {

This isn't quite a straight move - it's worth calling that out in the
changelog.

Attachment: signature.asc
Description: PGP signature