Re: [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes

[Hector Martin]

On 23/11/2021 07.58, Janne Grunau wrote:
> Apple M1 has at least 5 i2c controllers. i2c0, i2c1 and i2c3 are used
> on all M1 Mac devices. The 2020 Mac Mini uses i2c2 and the 13-inch
> MacBook Pro uses i2c2 and i2c4.
>
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/apple/t8103-j274.dts |  4 ++
>   arch/arm64/boot/dts/apple/t8103-j293.dts |  8 +++
>   arch/arm64/boot/dts/apple/t8103.dtsi     | 92 ++++++++++++++++++++++++
>   3 files changed, 104 insertions(+)

> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index c320c8baeb41..15fec48f943a 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -126,6 +126,73 @@ serial0: serial@235200000 {
>   			status = "disabled";
>   		};
>   
> +		i2c0: i2c@235010000 {
> +			compatible = "apple,t8103-i2c", "apple,i2c";
> +			reg = <0x2 0x35010000 0x0 0x4000>;
> +			clocks = <&clk24>;
[...]

Please put these before serial0; I want to keep the nodes sorted by address.

With that fixed:

Acked-by: Hector Martin <marcan@xxxxxxxxx>

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub