Re: [PATCH v2 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles

From: Mark Kettenis
Date: Mon Nov 22 2021 - 17:39:18 EST


> From: Janne Grunau <j@xxxxxxxxxx>
> Date: Mon, 22 Nov 2021 23:24:39 +0100
>
> The intention was to have a SoC-specific and base compatible string
> to allow forward compatibility and SoC specific quirks,
>
> Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings")
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> Cc: Mark Kettenis <kettenis@xxxxxxxxxxx>
> Reviewed-by: Sven Peter <sven@xxxxxxxxxxxxx>

Reviewed-by: Mark Kettenis <kettenis@xxxxxxxxxxx>

> ---
> Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index 22fc8483256f..82b953181a52 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -20,9 +20,9 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - apple,t8103-i2c
> - - apple,i2c
> + items:
> + - const: apple,t8103-i2c
> + - const: apple,i2c
>
> reg:
> maxItems: 1
> @@ -51,7 +51,7 @@ unevaluatedProperties: false
> examples:
> - |
> i2c@35010000 {
> - compatible = "apple,t8103-i2c";
> + compatible = "apple,t8103-i2c", "apple,i2c";
> reg = <0x35010000 0x4000>;
> interrupt-parent = <&aic>;
> interrupts = <0 627 4>;
> --
> 2.34.0
>
>