Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true

From: Abel Vesa
Date: Sat Nov 20 2021 - 15:18:33 EST


On 21-10-22 21:15:13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> The clock driver is registered as platform devices and
> it is possible to reloading the driver at runtime.
>
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all
> devices depends on clock to function well.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxx>

I'll apply it to clk/imx on Monday.

> ---
>
> V2:
> Update commit log to explain more
>
> drivers/clk/imx/clk-imx8ulp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> .probe = imx8ulp_clk_probe,
> .driver = {
> .name = KBUILD_MODNAME,
> + .suppress_bind_attrs = true,
> .of_match_table = imx8ulp_clk_dt_ids,
> },
> };
> --
> 2.30.0
>