Re: [PATCH] skbuff: Switch structure bounds to struct_group()

From: Jakub Kicinski
Date: Fri Nov 19 2021 - 13:53:11 EST


On Fri, 19 Nov 2021 10:41:44 -0800 Jakub Kicinski wrote:
> On Fri, 19 Nov 2021 10:26:19 -0800 Kees Cook wrote:
> > On Thu, Nov 18, 2021 at 11:13:55PM -0800, Jakub Kicinski wrote:
> > > This adds ~27k of these warnings to W=1 gcc builds:
> > >
> > > include/linux/skbuff.h:851:1: warning: directive in macro's argument list
> >
> > Hrm, I can't reproduce this, using several GCC versions and net-next. What
> > compiler version[1] and base commit[2] were used here?
>
> gcc version 11.2.1 20210728 (Red Hat 11.2.1-1) (GCC)
>
> HEAD was at: 3b1abcf12894 Merge tag 'regmap-no-bus-update-bits' of git://...

Ah, damn, I just realized, it's probably sparse! The build sets C=1.