Re: [PATCH] xen/pvh: add missing prototype to header

From: Dave Hansen
Date: Fri Nov 19 2021 - 11:47:54 EST


On 11/19/21 7:39 AM, Juergen Gross wrote:
> The prototype of mem_map_via_hcall() is missing in its header, so add
> it.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

$ git describe a43fb7da53007e67ad
v4.20-rc6-5-ga43fb7da5300

Better late than never, I guess. I wonder what made 0day find this now.

I also guess the one mem_map_via_hcall() call site just used the __weak
definition so it didn't cause problems if there wasn't a declaration in
the header.