Re: [PATCH 3/4] KVM: x86/pmu: Reuse find_perf_hw_id() and drop find_fixed_event()

From: Paolo Bonzini
Date: Thu Nov 18 2021 - 09:43:50 EST


On 11/16/21 13:20, Like Xu wrote:
+ /* return PERF_COUNT_HW_MAX as AMD doesn't have fixed events */
+ if (pmc_is_fixed(pmc))
+ return PERF_COUNT_HW_MAX;
+

This should have a WARN_ON, since reprogram_fixed_counter will never see an enabled fixed counter on AMD.

Paolo