Re: drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?

From: Sergio Paracuellos
Date: Wed Nov 17 2021 - 10:49:06 EST

Next message: Mark Brown: "Re: [PATCH 5/9] arm64: Make __get_wchan() use arch_stack_walk()"
Previous message: Lukasz Luba: "Re: [PATCH] base: arch_topology: Use policy->max to calculate freq_factor"
In reply to: kernel test robot: "drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

On Wed, Nov 17, 2021 at 4:13 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 8ab774587903771821b59471cc723bba6d893942
> commit: 2bdd5238e756aac3ecbffc7c22b884485e84062e PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver
> date: 4 weeks ago
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bdd5238e756aac3ecbffc7c22b884485e84062e
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 2bdd5238e756aac3ecbffc7c22b884485e84062e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash drivers/pci/controller/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
>
> sparse warnings: (new ones prefixed by >>)
> command-line: note: in included file:
> builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
> builtin:0:0: sparse: this was the original definition
> builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
> builtin:0:0: sparse: this was the original definition
> builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
> builtin:0:0: sparse: this was the original definition
> builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
> builtin:0:0: sparse: this was the original definition
> >> drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?

Thanks for reporting. Sparse is right. Symbol 'mt7621_pci_ops' should
be declared as static. Already sent patch with this change:
https://lkml.org/lkml/2021/11/17/635

Best regards,
Sergio Paracuellos

> drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:151:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:151:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:130:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:130:1: sparse: got void [noderef] __iomem *
> drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void const volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: expected void *
> arch/mips/include/asm/mips-cpc.h:100:1: sparse: got void [noderef] __iomem *
> drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void volatile [noderef] __iomem *mem
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@
> arch/mips/include/asm/mips-cm.h:202:1: sparse: expected void *
> arch/mips/include/asm/mips-cm.h:202:1: sparse: got void [noderef] __iomem *
> arch/mips/include/asm/mips-cm.h:209:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
>
> vim +/mt7621_pci_ops +151 drivers/pci/controller/pcie-mt7621.c
>
> 03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin 2018-03-15 150
> 8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03 @151 struct pci_ops mt7621_pci_ops = {
> 8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03 152 .map_bus = mt7621_pcie_map_bus,
> 8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03 153 .read = pci_generic_config_read,
> 8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03 154 .write = pci_generic_config_write,
> 03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin 2018-03-15 155 };
> 03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin 2018-03-15 156
>
> :::::: The code at line 151 was first introduced by commit
> :::::: 8571c62d45cb7e9fdff87fe5132002d17fbce7a3 staging: mt7621-pci: use generic kernel pci subsystem read and write
>
> :::::: TO: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> :::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Next message: Mark Brown: "Re: [PATCH 5/9] arm64: Make __get_wchan() use arch_stack_walk()"
Previous message: Lukasz Luba: "Re: [PATCH] base: arch_topology: Use policy->max to calculate freq_factor"
In reply to: kernel test robot: "drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]