Re: [PATCH V2 1/2] dt-bindings: Add YAML bindings for NVENC and NVJPG

[Jon Hunter]

On 17/11/2021 02:27, Rob Herring wrote:
> On Tue, 16 Nov 2021 15:54:12 +0000, Jon Hunter wrote:
> > Add YAML device tree bindings for the Tegra NVENC and NVJPG Host1x
> > engines.
> >
> > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> > ---
> > Changes since V1:
> > - Fixed errors reported by Rob's bot
> >
> >   .../gpu/host1x/nvidia,tegra210-nvenc.yaml     | 135 ++++++++++++++++++
> >   .../gpu/host1x/nvidia,tegra210-nvjpg.yaml     |  94 ++++++++++++
> >   2 files changed, 229 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvenc.yaml
> >   create mode 100644 Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvjpg.yaml
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvenc.yaml:103:10: [warning] wrong indentation: expected 10 but found 9 (indentation)
> ./Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvenc.yaml:104:13: [warning] wrong indentation: expected 11 but found 12 (indentation)


Darn, I did run the check and although saw the previous ones did not 
catch these.

> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade


Yes now I have upgraded and installed yamllint, I now see the above! I 
will resubmit. It is great having these tools now to catch this.

Thanks!
Jon

--
nvpublic