Re: [PATCH 1/3] serial: liteuart: fix compile testing

From: Johan Hovold
Date: Wed Nov 17 2021 - 04:07:11 EST


On Tue, Nov 16, 2021 at 05:44:14PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
> >
> > Allow the liteuart driver to be compile tested by fixing the broken
> > Kconfig dependencies.
>
> ...
>
> > config SERIAL_LITEUART
> > tristate "LiteUART serial port support"
> > + depends on LITEX || COMPILE_TEST
> > depends on HAS_IOMEM
> > - depends on OF || COMPILE_TEST
> > - depends on LITEX
>
> > + depends on OF
>
> AFAICS this is optional and prevents compile testing in some cases.

Yeah, you're right; that clause should stay. I'll send a v2. Thanks.

> > select SERIAL_CORE
> > help
> > This driver is for the FPGA-based LiteUART serial controller from LiteX

Johan