Re: [PATCH v2 1/2] tracing: Add helper functions to simplify event_command callback handling

[Steven Rostedt]

On Fri, 12 Nov 2021 14:23:39 -0600
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

>  
> +int event_trigger_check(char *glob, char **trigger, char **param,
> +			bool *remove, bool require_param, bool separate_trigger)

All these functions are going to require having kerneldoc comments for
them. I rather not have to try to figure out what these functions are for
and just read the documentation.

-- Steve


> +{
> +	int ret = 0;
> +
> +	*remove = (glob && glob[0] == '!') ? true : false;
> +