Re: [PATCH V3 0/9] arm64: imx8mn: Enable more imx8m Nano functions

From: Tim Harvey
Date: Tue Nov 16 2021 - 13:28:01 EST


On Tue, Nov 16, 2021 at 10:04 AM Adam Ford <aford173@xxxxxxxxx> wrote:
>
> On Tue, Nov 16, 2021 at 11:57 AM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote:
> >
> > On Thu, Nov 4, 2021 at 9:18 AM Adam Ford <aford173@xxxxxxxxx> wrote:
> > >
> > > The i.MX8M Nano is similar to the i.MX8M Mini in some ways, but very
> > > different in others. With the blk-ctrl driver for Mini in place,
> > > this series expands the blk-ctrl driver to support the Nano which
> > > opens the door for additional functions in the future. As part of
> > > this series, it also addresses some issues in the GPCv2 driver and
> > > finally adds support for enabling USB and GPU.
> > >
> > > V3: Fixes an the yaml example
> > > V2: Fixes the clock count in the blk-ctrl
> > >
> > > Adam Ford (9):
> > > soc: imx: gpcv2: keep i.MX8MN gpumix bus clock enabled
> > > soc: imx: gpcv2: Add dispmix and mipi domains to imx8mn
> > > dt-bindings: power: imx8mn: add defines for DISP blk-ctrl domains
> > > dt-bindings: soc: add binding for i.MX8MN DISP blk-ctrl
> > > soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl
> > > arm64: dts: imx8mn: add GPC node
> > > arm64: dts: imx8mn: put USB controller into power-domains
> > > arm64: dts: imx8mn: add DISP blk-ctrl
> > > arm64: dts: imx8mn: Enable GPU
> > >
> > > .../soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml | 97 +++++++++++++++++
> > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 103 ++++++++++++++++++
> > > drivers/soc/imx/gpcv2.c | 26 +++++
> > > drivers/soc/imx/imx8m-blk-ctrl.c | 75 ++++++++++++-
> > > include/dt-bindings/power/imx8mn-power.h | 5 +
> > > 5 files changed, 305 insertions(+), 1 deletion(-)
> > > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mn-disp-blk-ctrl.yaml
> > >
> >
> > Adam,
> >
> > Thanks for the patches. I'm not sure how best to test this but on an
> > imx8mm-venice-gw7902 which has USB, but no display.
> >
> > I find that if DRM_ETNAVIV is enabled I hang at 'etnaviv etnaviv:
> > bound 38000000.gpu (ops 0xffff800010964748)'.
>
> Thanks for testing this.
>
> Does your board send power to the GPU? I recall someone somewhere
> didn't power theirGPU, but I can't remember who and/or what board was
> being discussed.

Yes, the imx8mm-venice-gw7902 does have the GPU powered (the
imx8mm-venice-gw7901 was the one that did not).

Tim

>
> I'll run some more tests on the latest 5.16-rc1 to see if I can
> replicate your issue.
>
> adam
> >
> > If DRM_ETNAVIV is not enabled:
> > - boots fine
> > - usb works
> > - soft reboot works (does not hang)
>
> At least we have some progress. :-)
>
> adam
> >
> > Best regards,
> >
> > Tim