RE: [PATCH v2 3/3] soc: fsl: Replace kernel.h with the necessary inclusions

From: Leo Li
Date: Mon Nov 15 2021 - 19:11:35 EST




> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Monday, November 15, 2021 5:30 AM
> To: linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Cc: Leo Li <leoyang.li@xxxxxxx>; Qiang Zhao <qiang.zhao@xxxxxxx>
> Subject: Re: [PATCH v2 3/3] soc: fsl: Replace kernel.h with the necessary
> inclusions
>
> On Wed, Nov 10, 2021 at 12:59:52PM +0200, Andy Shevchenko wrote:
> > When kernel.h is used in the headers it adds a lot into dependency
> > hell, especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > v2: updated Cc list based on previous changes to MAINTAINERS
>
> Any comments on this, please?
>
> I really want to decrease amount of kernel.h usage in the common headers.
> So others won't copy'n'paste bad example.

There seems to be no problem with the patch although I didn't get time to really compile with it applied.

Will pick them up later after build test.

Regards,
Leo