Re: [PATCH] panic: use error_report_end tracepoint on warnings

From: Andy Shevchenko
Date: Mon Nov 15 2021 - 09:55:48 EST


On Mon, Nov 15, 2021 at 03:40:24PM +0100, Marco Elver wrote:
> On Mon, 15 Nov 2021 at 15:38, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote:

...

> > > ERROR_DETECTOR_KFENCE,
> > > - ERROR_DETECTOR_KASAN
> > > + ERROR_DETECTOR_KASAN,
> > > + ERROR_DETECTOR_WARN
> >
> > ...which exactly shows my point (given many times somewhere else) why comma
> > is good to have when we are not sure the item is a terminator one in the enum
> > or array of elements.
>
> So you want me to add a comma?

Yes. And you see exactly why I'm asking for that.

> (I'm not participating in bikeshedding here, just tell me what to do.)

Done!

--
With Best Regards,
Andy Shevchenko