Re: [PATCH RFC v2 2/2] mm: Rework swap handling of zap_pte_range

From: Matthew Wilcox
Date: Mon Nov 15 2021 - 08:58:43 EST


On Mon, Nov 15, 2021 at 09:49:51PM +0800, Peter Xu wrote:
> Clean the code up by merging the device private/exclusive swap entry handling
> with the rest, then we merge the pte clear operation too.
>
> struct* page is defined in multiple places in the function, move it upward.

Is that actually a good thing? There was a time when declaring
variables more locally helped compilers with liveness analysis and
register allocation. Compilers are probably smarter now.