Re: [PATCH AUTOSEL 4.19 10/47] NET: IPV4: fix error "do not initialise globals to 0"

[Sasha Levin]

On Mon, Nov 08, 2021 at 05:49:04PM -0800, Joe Perches wrote:
> On Mon, 2021-11-08 at 12:49 -0500, Sasha Levin wrote:
> > From: wangzhitong <wangzhitong@xxxxxxxxxxxxx>
> >
> > [ Upstream commit db9c8e2b1e246fc2dc20828932949437793146cc ]
> >
> > this patch fixes below Errors reported by checkpatch
> >     ERROR: do not initialise globals to 0
> >     +int cipso_v4_rbm_optfmt = 0;
> >
> > Signed-off-by: wangzhitong <wangzhitong@xxxxxxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  net/ipv4/cipso_ipv4.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> > index e8b8dd1cb1576..75908722de47a 100644
> > --- a/net/ipv4/cipso_ipv4.c
> > +++ b/net/ipv4/cipso_ipv4.c
> > @@ -87,7 +87,7 @@ struct cipso_v4_map_cache_entry {
> >  static struct cipso_v4_map_cache_bkt *cipso_v4_cache;
> >
> >  /* Restricted bitmap (tag #1) flags */
> > -int cipso_v4_rbm_optfmt = 0;
> > +int cipso_v4_rbm_optfmt;
>
> I think this is a silly thing to backport unless it's required
> for some other patch.

You're right - it's silly. I'll drop it.

--
Thanks,
Sasha