Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page

[Jens Axboe]

On 11/13/21 1:16 PM, Linus Torvalds wrote:
> On Sat, Nov 13, 2021 at 9:21 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>>
>> Maybe Andrew is out - Linus, if you follow this thread, there are two
>> proposed fixes for this. It'd be nice to have one of them in -rc1.
> 
> Neither of the fixes were sent to me, and honestly, I think the real
> issue is that the original commit is just too broken for words.
> 
> The error handling in that commit is just entirely lacking.
> 
> I've reverted the commit rather than try to fix up the breakage.
> 
> Because at some point it's just better to say "that was broken" rather
> than try to fix it up. And that original commit was too broken to be
> worth fixing up. It already had one fix for uninitialized variables
> before it even hit my tree, and then caused problems and had obvious
> broken error handling.

Thanks, that obviously fixes the problem as far as I'm concerned as well.

-- 
Jens Axboe