Re: [PATCH 3/5] iio: adc: ad_sigma_delta: Add sequencer support

From: Andy Shevchenko
Date: Sat Nov 13 2021 - 12:00:54 EST


On Fri, Nov 12, 2021 at 7:10 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Wed, 10 Nov 2021 13:17:48 +0200
> <alexandru.tachici@xxxxxxxxxx> wrote:


> > + kfree(sigma_delta->samples_buf);
>
> krealloc() preferred. It might not be necessary to actually do an allocation after all
> if we happen to have one we can already use.

Looking at below, shouldn't it be krealloc_array()?

> > + sigma_delta->samples_buf = kzalloc(slot * indio_dev->channels[0].scan_type.storagebits,
> > + GFP_KERNEL);


--
With Best Regards,
Andy Shevchenko