[RFC PATCH v2 11/11] selftests: KVM: aarch64: Add the bitmap firmware registers to get-reg-list

From: Raghavendra Rao Ananta
Date: Fri Nov 12 2021 - 20:25:14 EST


The bitmap firmware psuedo-registers needs special handling, such as
enabling the capability KVM_CAP_ARM_HVC_FW_REG_BMAP. Since there's
no support as of yet in get-reg-list to enable a capability, add a
field 'enable_capability' in the 'struct reg_sublist' to
incorporate this. Also, to not mess with the existing configurations,
create a new vcpu_config to hold these bitmap firmware registers.

Signed-off-by: Raghavendra Rao Ananta <rananta@xxxxxxxxxx>
---
.../selftests/kvm/aarch64/get-reg-list.c | 35 +++++++++++++++++++
1 file changed, 35 insertions(+)

diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
index cc898181faab..7479d0ae501e 100644
--- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
+++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
@@ -40,6 +40,7 @@ static __u64 *blessed_reg, blessed_n;
struct reg_sublist {
const char *name;
long capability;
+ long enable_capability;
int feature;
bool finalize;
__u64 *regs;
@@ -397,6 +398,19 @@ static void check_supported(struct vcpu_config *c)
}
}

+static void enable_capabilities(struct kvm_vm *vm, struct vcpu_config *c)
+{
+ struct reg_sublist *s;
+
+ for_each_sublist(c, s) {
+ if (s->enable_capability) {
+ struct kvm_enable_cap cap = {.cap = s->enable_capability};
+
+ vm_enable_cap(vm, &cap);
+ }
+ }
+}
+
static bool print_list;
static bool print_filtered;
static bool fixup_core_regs;
@@ -414,6 +428,7 @@ static void run_test(struct vcpu_config *c)
vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR);
prepare_vcpu_init(c, &init);
aarch64_vcpu_add_default(vm, 0, &init, NULL);
+ enable_capabilities(vm, c);
finalize_vcpu(vm, 0, c);

reg_list = vcpu_get_reg_list(vm, 0);
@@ -1014,6 +1029,12 @@ static __u64 sve_rejects_set[] = {
KVM_REG_ARM64_SVE_VLS,
};

+static __u64 fw_reg_bmap_set[] = {
+ KVM_REG_ARM_FW_REG(3), /* KVM_REG_ARM_STD_BMAP */
+ KVM_REG_ARM_FW_REG(4), /* KVM_REG_ARM_STD_HYP_BMAP */
+ KVM_REG_ARM_FW_REG(5), /* KVM_REG_ARM_VENDOR_HYP_BMAP */
+};
+
#define BASE_SUBLIST \
{ "base", .regs = base_regs, .regs_n = ARRAY_SIZE(base_regs), }
#define VREGS_SUBLIST \
@@ -1025,6 +1046,10 @@ static __u64 sve_rejects_set[] = {
{ "sve", .capability = KVM_CAP_ARM_SVE, .feature = KVM_ARM_VCPU_SVE, .finalize = true, \
.regs = sve_regs, .regs_n = ARRAY_SIZE(sve_regs), \
.rejects_set = sve_rejects_set, .rejects_set_n = ARRAY_SIZE(sve_rejects_set), }
+#define FW_REG_BMAP_SUBLIST \
+ { "fw_reg_bmap", .regs = fw_reg_bmap_set, .regs_n = ARRAY_SIZE(fw_reg_bmap_set), \
+ .capability = KVM_CAP_ARM_HVC_FW_REG_BMAP, \
+ .enable_capability = KVM_CAP_ARM_HVC_FW_REG_BMAP, }

static struct vcpu_config vregs_config = {
.sublists = {
@@ -1057,10 +1082,20 @@ static struct vcpu_config sve_pmu_config = {
},
};

+static struct vcpu_config vregs_fw_regs_bmap_config = {
+ .sublists = {
+ BASE_SUBLIST,
+ VREGS_SUBLIST,
+ FW_REG_BMAP_SUBLIST,
+ {0},
+ },
+};
+
static struct vcpu_config *vcpu_configs[] = {
&vregs_config,
&vregs_pmu_config,
&sve_config,
&sve_pmu_config,
+ &vregs_fw_regs_bmap_config,
};
static int vcpu_configs_n = ARRAY_SIZE(vcpu_configs);
--
2.34.0.rc1.387.gb447b232ab-goog