Re: [PATCH 0/4] spi: dw: Cleanup macros/funcs naming and add IP-core version support

[Andy Shevchenko]

On Fri, Nov 12, 2021 at 10:51 PM Serge Semin
<Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> This patchset consists of the changes which I was going to introduce for a
> long time, but due to lack of free time couldn't make it so far.
> Nandhini's series [1] made me to proceed with this task so mate would
> finally have his patchset accepted and merged into the mainline kernel.
>
> There are three cleanup patches here and one feature patch. In framework
> of the former patches we suggest to better organize the code. In
> particular they concern the methods and macros naming unification (using a
> unified prefixes of the code object names) and CSR fields macro
> implementation using the bitfield helpers available in the kernel. The
> later patch introduces the Synopsys Component Version register parsing
> procedure so the corresponding data could be used for a version-specific
> features implementation.  Nandhini will be mostly interested in the later
> patch in the framework of his series [1].
>
> Nandhini, could you please test the patchset out on your DWC SSI hardware?
> After it's merged into the spi/for-next branch of the Mark' repository you
> will be able to rebase your series on top of it and use the last patch
> functionality for your benefit.

Thanks!
I have no objection to the series, just a few nit-picks here and
there. Most important one is 4cc usage.

On top of that, please consider switching to use
EXPORT_SYMBOL_GPL_NS() (in a separate patch, perhaps as a
prerequisite).

Nevertheless,
Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

And with addressed above
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> [1] https://lore.kernel.org/linux-spi/20211111065201.10249-4-nandhini.srikandan@xxxxxxxxx/
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxx>
> Cc: linux-spi@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> Serge Semin (4):
>   spi: dw: Discard redundant DW SSI Frame Formats enumeration
>   spi: dw: Put the driver entities naming in order
>   spi: dw: Convert to using the Bitfield access macros
>   spi: dw: Add Synopsys Component version reading and parsing
>
>  drivers/spi/spi-dw-bt1.c  |   8 +-
>  drivers/spi/spi-dw-core.c | 165 ++++++++++++++++++++++----------------
>  drivers/spi/spi-dw-dma.c  |  50 ++++++------
>  drivers/spi/spi-dw-mmio.c |  20 ++---
>  drivers/spi/spi-dw-pci.c  |  59 +++++++-------
>  drivers/spi/spi-dw.h      | 150 +++++++++++++++++-----------------
>  6 files changed, 236 insertions(+), 216 deletions(-)
>
> --
> 2.33.0
>


-- 
With Best Regards,
Andy Shevchenko