Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL

From: Linus Walleij
Date: Thu Nov 11 2021 - 15:40:45 EST


On Wed, Nov 10, 2021 at 10:16 AM kernel test robot <lkp@xxxxxxxxx> wrote:

> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:15: error: 'struct gpio_chip' has no member named 'irq'
> 3068 | if (gc->irq.chip) {
> | ^~

Right you need an #ifdef CONFIG_GPIOLIB_IRQCHIP in this
case I would try:

if (IS_ENABLED(CONFIG_GPIOLIB_IRQCHIP) && gc->irq.chip)

hoping the compiler is smart enough to deal with that
(but I'm not sure it is)

Yours,
Linus Walleij