Re: [PATCH] gpio: xlp: Remove Netlogic XLP variants

From: Linus Walleij
Date: Thu Nov 11 2021 - 15:28:31 EST


On Thu, Nov 11, 2021 at 9:13 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Thu, Nov 11, 2021 at 4:43 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > > @@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev)
> > > gc->label = dev_name(&pdev->dev);
> > > gc->base = 0;
> >
> > Can we also set this to -1 and use dynamic GPIO base allocation?
> > (Can be a separate patch.)
>
> No clue. What's normal for GPIO ACPI systems?

Dynamic allocation (-1) c.f.
drivers/pinctrl/intel/pinctrl-intel.c

> Does that mean more than
> 1 instance is broken currently?

Yes.

Yours,
Linus Walleij