Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

From: Alim Akhtar
Date: Thu Nov 11 2021 - 11:29:17 EST


Hi Krzysztof,

On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> arch/arm/mach-s3c/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
> #include "gpio-core.h"
> #include "gpio-cfg.h"
> #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
> #include "pm.h"
>
> int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>


--
Regards,
Alim