Re: [PATCH V2 0/4] mm/damon: Do some small changes

[SeongJae Park]

Hello Xin,

On Thu, 11 Nov 2021 14:07:00 +0800 Xin Hao <xhao@xxxxxxxxxxxxxxxxx> wrote:

> These four patches are mainly to do some small changes.
> 
> V1 -> V2
> 	Add reviewed by SeongJae Park
> 	Add two new patches
> V1:
> https://lore.kernel.org/linux-mm/cover.1636546262.git.xhao@xxxxxxxxxxxxxxxxx/
> 
> 
> Xin Hao (4):
>   mm/damon: Unified access_check function naming rules
>   mm/damon: Add 'age' of region tracepoint support
>   mm/damon/core: Using function abs() instead of diff_of()
>   mm/damon: Remove some no need func definitions in damon.h file

Overall, all patches looks good to me, though I asked[1] a trivial change in
the commit message of the second patch.

Also, I found one interesting thing.  It seems you are wrapping body of the
commit messages at <75 columns[2]?  That's obviously neither a problem, nor
even trivial nit.  But... I'd prefer the messages look more consistent with
others.

[1] https://lore.kernel.org/linux-mm/20211111082034.13323-1-sj@xxxxxxxxxx/
[2] https://docs.kernel.org/process/submitting-patches.html?highlight=75#the-canonical-patch-format


Thanks,
SJ

> 
>  include/linux/damon.h        | 25 ++-----------------------
>  include/trace/events/damon.h |  7 +++++--
>  mm/damon/core.c              |  6 ++----
>  mm/damon/vaddr.c             |  8 ++++----
>  4 files changed, 13 insertions(+), 33 deletions(-)
> 
> --
> 2.31.0