Re: [PATCH V1 1/2] mm/damon: Unified access_check function naming rules

[SeongJae Park]

On Wed, 10 Nov 2021 20:13:13 +0800 Xin Hao <xhao@xxxxxxxxxxxxxxxxx> wrote:

> In damon/paddr.c file, two functions names start with underscore,
> 	static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> 			struct damon_region *r)
> 	static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> 			struct damon_region *r)
> In damon/vaddr.c file, there are also two functions with the same function,
> 	static void damon_va_prepare_access_check(struct damon_ctx *ctx,
> 			struct mm_struct *mm, struct damon_region *r)
> 	static void damon_va_check_access(struct damon_ctx *ctx,
> 			struct mm_struct *mm, struct damon_region *r)
> 
> It makes sense to keep consistent, and it is not easy to be confused with
> the function that call them.
> 
> Signed-off-by: Xin Hao <xhao@xxxxxxxxxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]