Re: [PATCH v12 1/2] tty: hvc: pass DMA capable memory to put_chars()

From: Jiri Slaby
Date: Wed Nov 10 2021 - 04:50:45 EST


On 04. 11. 21, 14:06, Xianting Tian wrote:
OTOH, you need c[N_OUTBUF] in the console case (hvc_console_print), but
not whole hvc_struct. So cons_hvcs should be an array of structs
composed of only the lock and the buffer.
It is ok for me.
=============

And I would do it even simpler now. One c[N_OUTBUF] buffer for all consoles and a single lock.

And "char c" in struct hvc_struct.

No need for the complex logic in hvc_console_print.

So you will implement this?

No, there is a slight difference between "I would" and "I will" :). I don't have anything to test this hvc change on…

thanks,
--
js
suse labs