Re: [PATCH] nvme: fix write zeroes pi

From: Chaitanya Kulkarni
Date: Wed Nov 10 2021 - 01:10:23 EST


Klaus,

On 11/4/2021 11:16 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@xxxxxxxxxxx>
>
> Write Zeroes sets PRACT when block integrity is enabled (as it should),
> but neglects to also set the reftag which is expected by reads. This
> causes protection errors on reads.
>
> Fix this by setting the reftag for type 1 and 2 (for type 3, reads will
> not check the reftag).
>
> Signed-off-by: Klaus Jensen <k.jensen@xxxxxxxxxxx>

Patch looks good to me but did you get a chance to test on
multiple non-QEMU controllers ?