Re: [PATCH v2 1/2] SPI: Add SPI driver for Sunplus SP7021

[Randy Dunlap]

On 11/9/21 9:39 PM, Lh Kuo 郭力豪 wrote:
> Hi
>
> > -----Original Message-----
> > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Sent: Wednesday, November 10, 2021 12:55 AM
> > To: LH.Kuo <lhjeff911@xxxxxxxxx>; p.zabel@xxxxxxxxxxxxxx;
> > broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Cc: dvorkin@xxxxxxxxx; qinjian@xxxxxxxxxxx; Wells Lu 呂芳騰
> > <wells.lu@xxxxxxxxxxx>; Lh Kuo 郭力豪 <lh.Kuo@xxxxxxxxxxx>
> > Subject: Re: [PATCH v2 1/2] SPI: Add SPI driver for Sunplus SP7021
> >
> > On 11/9/21 1:01 AM, LH.Kuo wrote:
> > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index
> > > 596705d..30ce0ed 100644
> > > --- a/drivers/spi/Kconfig
> > > +++ b/drivers/spi/Kconfig
> > > @@ -866,6 +866,17 @@ config SPI_SUN6I
> > >    	help
> > >    	  This enables using the SPI controller on the Allwinner A31 SoCs.
> > >
> > > +config SPI_SUNPLUS_SP7021
> > > +	tristate "Sunplus SP7021 SPI controller"
> > > +	depends on SOC_SP7021
> > > +	help
> > > +	  This enable Sunplus SP7021 spi controller driver on the SP7021 SoCs.
> >
> > 	       enables the Sunplus SP021 SPI
> >
> > > +	  This driver can also be built as a module. If so, the module will be
> > > +	  called as spi-sunplus-sp7021.
> > > +
> > > +	  If you have a  Sunplus SP7021 platform say Y here.
> >
> > 	         have a Sunplus
> > (i.e., drop one space)
> >
> > > +	  If unsure, say N.
>
> I will make change as below  is it OK ?
>
> config SPI_SUNPLUS_SP7021
> 	tristate "Sunplus SP7021 SPI controller"
> 	depends on SOC_SP7021
> 	help
> 	  This enable Sunplus SP7021 spi controller driver on the SP7021 SoCs.

	       enables               SPI

> 	  This driver can also be built as a module. If so, the module will be
> 	  called as spi-sunplus-sp7021.
>
> 	  If you have a  Sunplus SP7021 platform say Y here.

drop one space:       a Sunplus

> 	  If unsure, say N.
>
> > --
> > ~Randy


--
~Randy