drivers/net/ethernet/smsc/smc91x.c:634:23: warning: variable 'flags' set but not used

From: kernel test robot
Date: Wed Nov 10 2021 - 00:31:39 EST

Next message:
Previous message:
Messages sorted

Hi Andrew,

First bad commit (maybe !=
tree: config: microblaze-randconfig-r012-20210927 compiler: microblaze-linux-gcc reproduce (this is a W=1 build):
wget # If you fix the issue, kindly Reported-by: kernel test robot
All warnings (new ones prefixed
drivers/net/ethernet/smsc/smc91x.c: >> drivers/net/ethernet/sm 634 | unsigned |

vim +/flags +634 drivers/net/ethern
^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 6323d57f335ce1 drivers/net/ethernet 6323d57f335ce1 drivers/net/ethernet ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 8ff499e43c5376 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 6389aa458ed995 drivers/net/ethernet ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 6389aa458ed995 drivers/net/ethernet 09f75cd7bf1372 drivers/net/smc91x.c 09f75cd7bf1372 drivers/net/smc91x.c 4b61fe2621e40f drivers/net/ethernet 6ed106549d1747 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 8ff499e43c5376 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c cfdfa86536d2fb drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c cfdfa86536d2fb drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c cfdfa86536d2fb drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 8ff499e43c5376 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c be83668a253149 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 6389aa458ed995 drivers/net/ethernet cfdfa86536d2fb drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 7961fb1089f826 drivers/net/ethernet ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c 6ed106549d1747 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c ^1da177e4c3f41 drivers/net/smc91x.c
:::::: The code at line 634 :::::: 8ff499e43c537648399fca8ba39d24c0768b3fab
:::::: TO: Dongdong Deng <dongdo :::::: CC: David S. Miller
---
0-DAY CI Kernel Test Service, Description: application/gzip Apeksha Gupta: "[PATCH 0/3] drivers/net: split FEC driver" Jiri Slaby: "Re: [PATCH] tty: vt: keyboard: do not copy an extra-byte in copy_to_user" by: [ date ] [ thread ] [ subject ] [ author ] root cause):
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
9237cf53a877c
drivers: net: smsc: Add COMPILE_TEST support
(attached as .config)
(GCC) 11.2.0
href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7958ba7e6273a02f49432a2506958d0f59b5b8da">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7958ba7e6273a02f49432a2506958d0f59b5b8da
rel="nofollow" href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
linus master
2f49432a2506958d0f59b5b8da
.config to linux build tree
COMPILER=gcc-11.2.0 make.cross ARCH=microblaze
add following tag as appropriate
<lkp@xxxxxxxxx>
by >>):
In function 'smc_hard_start_xmit':
sc/smc91x.c:634:23: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
long flags;
^~~~~
et/smsc/smc91x.c
Linus Torvalds 2005-04-16 621
Linus Torvalds 2005-04-16 622 /*
Linus Torvalds 2005-04-16 623 * Since I am not sure if I will have enough room in the chip's ram
Linus Torvalds 2005-04-16 624 * to store the packet, I call this routine which either sends it
Linus Torvalds 2005-04-16 625 * now, or set the card to generates an interrupt when ready
Linus Torvalds 2005-04-16 626 * for the packet.
Linus Torvalds 2005-04-16 627 */
/smsc/smc91x.c YueHaibing 2018-09-26 628 static netdev_tx_t
/smsc/smc91x.c YueHaibing 2018-09-26 629 smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
Linus Torvalds 2005-04-16 630 {
Linus Torvalds 2005-04-16 631 struct smc_local *lp = netdev_priv(dev);
Linus Torvalds 2005-04-16 632 void __iomem *ioaddr = lp->base;
Linus Torvalds 2005-04-16 633 unsigned int numPages, poll_count, status;
Dongdong Deng 2009-08-23 @634 unsigned long flags;
Linus Torvalds 2005-04-16 635
/smsc/smc91x.c Ben Boeckel 2013-11-01 636 DBG(3, dev, "%s\n", __func__);
Linus Torvalds 2005-04-16 637
Linus Torvalds 2005-04-16 638 BUG_ON(lp->pending_tx_skb != NULL);
Linus Torvalds 2005-04-16 639
Linus Torvalds 2005-04-16 640 /*
Linus Torvalds 2005-04-16 641 * The MMU wants the number of pages to be the number of 256 bytes
Linus Torvalds 2005-04-16 642 * 'pages', minus 1 (since a packet can't ever have 0 pages :))
Linus Torvalds 2005-04-16 643 *
Linus Torvalds 2005-04-16 644 * The 91C111 ignores the size bits, but earlier models don't.
Linus Torvalds 2005-04-16 645 *
Linus Torvalds 2005-04-16 646 * Pkt size for allocating is data length +6 (for additional status
Linus Torvalds 2005-04-16 647 * words, length and ctl)
Linus Torvalds 2005-04-16 648 *
Linus Torvalds 2005-04-16 649 * If odd size then last byte is included in ctl word.
Linus Torvalds 2005-04-16 650 */
Linus Torvalds 2005-04-16 651 numPages = ((skb->len & ~1) + (6 - 1)) >> 8;
Linus Torvalds 2005-04-16 652 if (unlikely(numPages > 7)) {
/smsc/smc91x.c Ben Boeckel 2013-11-01 653 netdev_warn(dev, "Far too big packet error.\n");
Jeff Garzik 2007-10-03 654 dev->stats.tx_errors++;
Jeff Garzik 2007-10-03 655 dev->stats.tx_dropped++;
/smsc/smc91x.c Eric W. Biederman 2014-03-15 656 dev_kfree_skb_any(skb);
Patrick McHardy 2009-06-23 657 return NETDEV_TX_OK;
Linus Torvalds 2005-04-16 658 }
Linus Torvalds 2005-04-16 659
Dongdong Deng 2009-08-23 660 smc_special_lock(&lp->lock, flags);
Linus Torvalds 2005-04-16 661
Linus Torvalds 2005-04-16 662 /* now, try to allocate the memory */
Magnus Damm 2008-02-22 663 SMC_SET_MMU_CMD(lp, MC_ALLOC | numPages);
Linus Torvalds 2005-04-16 664
Linus Torvalds 2005-04-16 665 /*
Linus Torvalds 2005-04-16 666 * Poll the chip for a short amount of time in case the
Linus Torvalds 2005-04-16 667 * allocation succeeds quickly.
Linus Torvalds 2005-04-16 668 */
Linus Torvalds 2005-04-16 669 poll_count = MEMORY_WAIT_TIME;
Linus Torvalds 2005-04-16 670 do {
Magnus Damm 2008-02-22 671 status = SMC_GET_INT(lp);
Linus Torvalds 2005-04-16 672 if (status & IM_ALLOC_INT) {
Magnus Damm 2008-02-22 673 SMC_ACK_INT(lp, IM_ALLOC_INT);
Linus Torvalds 2005-04-16 674 break;
Linus Torvalds 2005-04-16 675 }
Linus Torvalds 2005-04-16 676 } while (--poll_count);
Linus Torvalds 2005-04-16 677
Dongdong Deng 2009-08-23 678 smc_special_unlock(&lp->lock, flags);
Linus Torvalds 2005-04-16 679
Nicolas Pitre 2005-06-19 680 lp->pending_tx_skb = skb;
Linus Torvalds 2005-04-16 681 if (!poll_count) {
Linus Torvalds 2005-04-16 682 /* oh well, wait until the chip finds memory later */
Linus Torvalds 2005-04-16 683 netif_stop_queue(dev);
/smsc/smc91x.c Ben Boeckel 2013-11-01 684 DBG(2, dev, "TX memory allocation deferred.\n");
Magnus Damm 2008-02-22 685 SMC_ENABLE_INT(lp, IM_ALLOC_INT);
Linus Torvalds 2005-04-16 686 } else {
Linus Torvalds 2005-04-16 687 /*
Linus Torvalds 2005-04-16 688 * Allocation succeeded: push packet to the chip's own memory
Linus Torvalds 2005-04-16 689 * immediately.
Linus Torvalds 2005-04-16 690 */
/smsc/smc91x.c Allen Pais 2020-09-14 691 smc_hardware_send_pkt(&lp->tx_task);
Linus Torvalds 2005-04-16 692 }
Linus Torvalds 2005-04-16 693
Patrick McHardy 2009-06-23 694 return NETDEV_TX_OK;
Linus Torvalds 2005-04-16 695 }
Linus Torvalds 2005-04-16 696
was first introduced by commit
smc91x: let smc91x work well under netpoll
ng.deng@xxxxxxxxxxxxx>
<davem@xxxxxxxxxxxxx>
Intel Corporation
sts.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Apeksha Gupta: "[PATCH 0/3] drivers/net: split FEC driver"
Previous message: Jiri Slaby: "Re: [PATCH] tty: vt: keyboard: do not copy an extra-byte in copy_to_user"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]