Re: [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support

[Andrew Lunn]

> +static int
> +qca8k_parse_netdev(unsigned long rules, u32 *offload_trigger, u32 *mask)

This is a rather oddly named function, given that it is not actually
passed a netdev. netdev has a very well defined meaning in the network
stack, struct net_device.

       Andrew