Re: [PATCH 0/1] device property: Adding fwnode_irq_get_by_name()

[Puranjay Mohan]

On Wed, Nov 10, 2021 at 1:15 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 10, 2021 at 01:00:26AM +0530, Puranjay Mohan wrote:
> > On Sun, Nov 7, 2021 at 1:59 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Sat, Nov 06, 2021 at 11:09:08PM +0530, Puranjay Mohan wrote:
> > > > While working on an IIO driver I was told to use of_irq_get_byname() as
> > > > the generic version is not available in property.c.
> > > > I wish to work on this and have written a function that may work.
> > > > I am not sure about its correctness so I am posting this patch early for
> > > > review.
> > >
> >
> > Hi Greg,
> >
> > > Please test your code, and also provide a user for it.  We can not take
> > > new functions that no one uses as that usually means they do not work.
> >
> > Actually, I just wanted to get a review of this code before I test it.
>
> No, please test your code first, before asking others to review it.
>

Sorry for this inconvenience.
Actually, I have never worked on this part of the kernel before so I
was not sure if I was doing the right thing.
Now, I have tested it and sent a new version.

P.S - I won't send untested code again.

> Do you want to spend your time reviewing code that the creator has not
> even tested themselves?
>
> thanks,
>
> greg k-h

Thanks,
Puranjay Mohan