Re: [PATCH v2 2/7] net: dsa: b53: Move struct b53_device to include/linux/dsa/b53.h

From: Florian Fainelli
Date: Tue Nov 09 2021 - 13:05:57 EST


On 11/9/21 1:50 AM, Martin Kaistra wrote:
> In order to access the b53 structs from net/dsa/tag_brcm.c move the
> definitions from drivers/net/dsa/b53/b53_priv.h to the new file
> include/linux/dsa/b53.h.
>
> Signed-off-by: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx>
> ---
> drivers/net/dsa/b53/b53_priv.h | 90 +----------------------------
> include/linux/dsa/b53.h | 100 +++++++++++++++++++++++++++++++++
> 2 files changed, 101 insertions(+), 89 deletions(-)
> create mode 100644 include/linux/dsa/b53.h

All you really access is the b53_port_hwtstamp structure within the
tagger, so please make it the only structure exposed to net/dsa/tag_brcm.c.
--
Florian